Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Touchpoints yes/no poll #694

Merged
merged 5 commits into from
Oct 17, 2023
Merged

Touchpoints yes/no poll #694

merged 5 commits into from
Oct 17, 2023

Conversation

kewitham
Copy link
Collaborator

@kewitham kewitham commented Sep 20, 2023 •
edited
Loading

This PR adds the "Was this page helpful" touchpoints question for pages with and without a sidenav.

image

image

@github-actions
Copy link

🔍 Preview in Federalist

@kewitham kewitham changed the title Touchpoints poll mock Touchpoints yes/no poll Sep 27, 2023
okkays
okkays requested changes Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@okkays okkays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it'd be worth it to hide "Submit" and add a click handler to the "Yes / No" which automatically clicks the "Submit"? (That way we could hide the submit button and it'd just have the "Yes/No"

_layouts/default.html Show resolved Hide resolved
_layouts/page.html Show resolved Hide resolved
@kewitham kewitham requested a review from okkays October 6, 2023 19:27
vwilliamsn
vwilliamsn approved these changes Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@vwilliamsn vwilliamsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @kewitham!

sanchez-amanda
sanchez-amanda approved these changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@sanchez-amanda sanchez-amanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!!!

okkays
okkays approved these changes Oct 17, 2023
View reviewed changes
_assets/js/touchpoints-page-helpful.js Outdated Show resolved Hide resolved
@kewitham kewitham merged commit 2df375b into main Oct 17, 2023
1 of 2 checks passed
@kewitham kewitham deleted the kw/862/touchpoints-poll branch October 17, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanchez-amanda sanchez-amanda sanchez-amanda approved these changes

@vwilliamsn vwilliamsn vwilliamsn approved these changes

@okkays okkays okkays approved these changes

@c2nelson c2nelson Awaiting requested review from c2nelson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kewitham @okkays @vwilliamsn @sanchez-amanda