Fixes to balance calculations on Aave V3 and Beefy

usePicnic · Nov 14, 2023 · b2bb07b · b2bb07b
1 parent ee0a6c3
commit b2bb07b
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/core/src/asset-strategies/AaveV3DepositStrategy.ts b/core/src/asset-strategies/AaveV3DepositStrategy.ts
@@ -117,7 +117,7 @@ export class AaveV3DepositStrategy extends InterfaceStrategy {
       routerOperation.steps.push({
         stepAddress: asset.address,
         stepEncodedCall: IERC20.encodeFunctionData("balanceOf", [
-          asset.address,
+          walletAddress,
         ]),
         storeOperations: [
           {
@@ -156,14 +156,14 @@ export class AaveV3DepositStrategy extends InterfaceStrategy {
       routerOperation.steps.push({
         stepAddress: asset.address,
         stepEncodedCall: IERC20.encodeFunctionData("balanceOf", [
-          asset.address,
+          walletAddress,
         ]),
         storeOperations: [
           {
             storeOpType: StoreOpType.RetrieveResultAddStore,
             storeNumber: storeNumberTo,
             offset: balanceOfToOffsets[0],
-            fraction: newFraction * FRACTION_MULTIPLIER,
+            fraction: FRACTION_MULTIPLIER,
           },
           {
             storeOpType: StoreOpType.SubtractStoreFromStore,

diff --git a/core/src/asset-strategies/BeefyDepositStrategy.ts b/core/src/asset-strategies/BeefyDepositStrategy.ts
@@ -134,7 +134,7 @@ export class BeefyDepositStrategy extends InterfaceStrategy {
       routerOperation.steps.push({
         stepAddress: asset.address,
         stepEncodedCall: IERC20.encodeFunctionData("balanceOf", [
-          asset.address,
+          walletAddress,
         ]),
         storeOperations: [
           {
@@ -170,7 +170,7 @@ export class BeefyDepositStrategy extends InterfaceStrategy {
       routerOperation.steps.push({
         stepAddress: asset.address,
         stepEncodedCall: IERC20.encodeFunctionData("balanceOf", [
-          asset.address,
+          walletAddress,
         ]),
         storeOperations: [
           {

diff --git a/core/tests/protocols/beefy.spec.ts b/core/tests/protocols/beefy.spec.ts
@@ -10,7 +10,7 @@ test("generateTransaction: USDC to QUICK (beefyDeposit)", async () => {
   });
 });
 
-test.skip("generateTransaction: beefy.finance (beefyDeposit) to USDC", async () => {
+test("generateTransaction: beefy.finance (beefyDeposit) to USDC", async () => {
   await simulateSingleAssetToSingleAsset({
     chainId: 137,
     inputAssetId: "fecfd33d-e6a7-476b-89cb-910a0058fa48",