Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: add sync before umount #10

Merged
merged 1 commit into from
Jan 22, 2025
Merged

src: add sync before umount #10

merged 1 commit into from
Jan 22, 2025

Conversation

adityamaru
Copy link

@adityamaru adityamaru commented Jan 22, 2025

Important

Adds sync command in run() in post.ts to flush writes before unmounting a disk.

  • Behavior:
    • Adds await execAsync('sync'); in run() in post.ts to flush pending writes before unmounting a disk.
  • Comments:
    • Updates comment in run() to reflect the addition of the sync command before unmounting.

This description was created by Ellipsis for a85354c. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to a85354c in 9 seconds

More details
  • Looked at 16 lines of code in 1 files
  • Skipped 1 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. src/post.ts:84
  • Draft comment:
    Consider handling potential errors from the 'sync' command to ensure any issues are logged and addressed.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The use of 'sync' before unmounting is a good practice to ensure data integrity. However, the use of 'execAsync' with 'sync' and 'umount' commands should handle potential errors.

Workflow ID: wflow_Ehk2UP0fpwvR1g9l


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@adityamaru adityamaru merged commit 9c61fba into main Jan 22, 2025
1 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants