Galaxy-sync.to-nfs: add check and ensure galaxy user #1353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mira-miracoli
changed the title
bgruening
reviewed
Nov 13, 2024
| @@ -3,6 +3,10 @@ | |||
| copy: | |||
| content: | | |||
| #!/bin/bash | |||
| if [ "$(whoami)" != "galaxy" ]; then | |||
| exec sudo -u galaxy bash "$0" "$@" | |||
There was a problem hiding this comment.
isn't that unexpected for a user?
Can we maybe instead just run the rsync command as galaxyuser?
There was a problem hiding this comment.
From my understanding this checks if the user is not galaxy and if true runs the whole script as galaxy user and exits the old invocation.
When I test the same but with root instead of galaxy on my laptop (and an echo $(whoami)), the user stays the same in my shell session. just changes for the time of the script execution:
bgruening
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because we sometimes have this file permission error, when we forget and run the script as root user