Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tpv variable for cooler_cload_tabix tool #1368

Merged

Conversation

SaimMomin12
Copy link
Contributor

No description provided.

@bgruening
Copy link
Member

@sanjaysrikakulam ORG has this change in the default tool. https://github.com/galaxyproject/usegalaxy-playbook/blob/08336fc92f658dd34714f6d8408d02c56502c905/env/common/templates/galaxy/config/tpv/defaults.yaml.j2#L28

I think we should do similar... What do you think.
We need this pr urgently for a collaboration and a failing tool. But a general solution would be nice

@bgruening
Copy link
Member

See line 390/395 @SaimMomin12

@SaimMomin12
Copy link
Contributor Author

@bgruening Should this be updated in the following way?

env: 
    - HDF5_USE_FILE_LOCKING: "FALSE"

@sanjaysrikakulam
Copy link
Member

@sanjaysrikakulam ORG has this change in the default tool. https://github.com/galaxyproject/usegalaxy-playbook/blob/08336fc92f658dd34714f6d8408d02c56502c905/env/common/templates/galaxy/config/tpv/defaults.yaml.j2#L28

I think we should do similar... What do you think. We need this pr urgently for a collaboration and a failing tool. But a general solution would be nice

Yes, setting it in the tool default is fine, I think (I did not find it set to True anywhere in the ORG's confs). I have pushed a new commit adding the ENV HDF5_USE_FILE_LOCKING: "False" to tool default and removed the tool-specific setting and the tool entry since the tool does not have any exclusive requirements. Feel free to merge and deploy.

@bgruening
Copy link
Member

@sanjaysrikakulam wants to go all in - nice. Please feel free to merge and redeploy. Can you let @SaimMomin12 know when it was restarted?

@sanjaysrikakulam sanjaysrikakulam merged commit d86969b into usegalaxy-eu:master Nov 28, 2024
4 checks passed
@sanjaysrikakulam
Copy link
Member

@SaimMomin12, the config is deployed. Please test.

@SaimMomin12
Copy link
Contributor Author

SaimMomin12 commented Nov 29, 2024

@sanjaysrikakulam thanks for the quick patch, I will test the tool and let you know :)

Edit: The issue has been resolved and the tool works fine now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants