Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have a look at the storage stats, jwd05e is almost full while jwd02f is almost empty, despite both having the same weight (something is must be wrong with the job distribution).
I spent some time this morning familiarizing myself with the mechanism that chooses a storage backend to send new jobs to and at first glance the code looks legit, so I do not know what is causing the skew. There is a mechanism to exclude storage backends that are almost full, but the feature seems to be unfinished. I have tried it and some storage backends do not have the function that computes the free space implemented (e.g. S3).
For a few hours (since about 13:08), we have been operating like in this PR without issues: sending 70% of jobs to jwd02f and 30% to jwd05e.
The change seems to work properly.
Which arguably is weird, because if it works, the storage distribution should not have been skewed in the first place. Maybe we are storing something in jwd05e that we should not be storing?
If you want we can keep this for a day or two and then revert while we find out. Otherwise we may hit the storage limit soon. Sadly I have already cleaned up the job working directories for failed jobs 😞.