Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dioscuri migration uses invalid base64 decode flag #279

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

rocketeerbkw
Copy link
Member

An error was introduced in #265 due to invalid base64 flag:

base64: unrecognized option: decode
BusyBox v1.36.0 (2023-05-05 06:41:49 UTC) multi-call binary.

Usage: base64 [-d] [-w COL] [FILE]

Base64 encode or decode FILE to standard output

	-d	Decode data
	-w COL	Wrap lines at COL (default 76, 0 disables)

This PR removes the call to base64 altogether in favor of jq. Tested in a live build-deploy-tool pod.

Copy link
Member

@shreddedbacon shreddedbacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@shreddedbacon shreddedbacon merged commit b849107 into main Dec 12, 2023
2 checks passed
@shreddedbacon shreddedbacon deleted the fix-dioscuri-migration branch December 12, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants