fix: remove the secret when tls-acme is set to false #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domcyrus
reviewed
Jan 15, 2024
shreddedbacon
force-pushed
the
cleanup-ingress-secret
branch
2 times, most recently
from
35cad27 to
d139c04
Compare
shreddedbacon
changed the title
shreddedbacon
force-pushed
the
cleanup-ingress-secret
branch
from
d139c04 to
efab999
Compare
tobybellwood
approved these changes
Feb 13, 2024
shreddedbacon
force-pushed
the
cleanup-ingress-secret
branch
from
efab999 to
26e5532
Compare
|
Just rebased on main, no changes otherwise |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In combination with uselagoon/lagoon#3638, this fixes the behaviour of when
tls-acme: trueis changed tofalseso that it also correctly cleans up the certificate being served.closes #290