refactor: use new insights.lagoon.sh/type label #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobybellwood
approved these changes
Feb 26, 2024
shreddedbacon
changed the title
shreddedbacon
approved these changes
Feb 26, 2024
|
Is there an order of release required for this, does it rely on another component to exist or have changes rolled out before this is merged and released, or can it be merged without another system requiring an update? |
|
@shreddedbacon no dependencies :) can be rolled out as is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an explicit label used for typing insights ConfigMap data.
It essentially duplicates the data that is currently in the
lagoon.sh/insightsTypelabel, but brings it in line with this proposal.Furthermore, by dropping the
-gzdesignation in the type, we are pointing towards the proposed introduction of stricter types for insights-remote. With regards to this, note how the newinsights.lagoon.sh/typedoes not reference whether the data is compressed or not - this acknowledges that we will only process compressed binary data forsbomandinspecttypes going forward.