New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check secret exists before trying to read or delete it #384

Merged

shreddedbacon merged 1 commit into main from fix-tls-challenge-cleanup

Oct 21, 2024

Member

shreddedbacon commented Oct 15, 2024

Just a quick one to check that the secret of an ingress exists before trying to access it to verify if it needs to be deleted.

Also ensure that the name of the secret is correctly used, not with the -tls suffix, as this is already in the variable.


          fix: check secret exists before trying to read or delete it

79ba989

shreddedbacon added this to the 2.22.0 milestone

shreddedbacon marked this pull request as ready for review

October 15, 2024 06:32

tobybellwood approved these changes

View reviewed changes

Member

tobybellwood left a comment

Nice easy change, ok to merge

shreddedbacon merged commit d039fc9 into main

2 checks passed

shreddedbacon deleted the fix-tls-challenge-cleanup branch

October 21, 2024 21:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet