feat: add valkey service type #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreddedbacon
commented
Oct 21, 2024
shreddedbacon
force-pushed
the
valkey-service-type
branch
from
5ea15e0 to
e0ce910
Compare
shreddedbacon
force-pushed
the
valkey-service-type
branch
3 times, most recently
from
befb312 to
3aa66f0
Compare
shreddedbacon
force-pushed
the
valkey-service-type
branch
from
3aa66f0 to
5befa26
Compare
tobybellwood
approved these changes
Nov 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a supporting
valkeyservice type for the recently released Valkey images.Currently the
redisandvalkeytypes are identical except for the name. But if the projects diverge further, or there are changes specific to Valkey that need to be made, the new type should be used.This may be difficult for existing users that currently use the
redisservice types since changing types in Lagoon is not currently possible without significant effort. With #274 though, it would be possible to delete aredisservice and create a new one calledvalkey. Persistent versions using this would experience data loss.