refactor: split build and push to independent steps #390
Conversation
shreddedbacon
force-pushed
the
image-build-push-steps
branch
from
1aea8a2 to
9f56c6e
Compare
shreddedbacon
force-pushed
the
image-build-push-steps
branch
from
9f56c6e to
a3bae64
Compare
| fi | ||
| else | ||
| previousStepEnd=${currentStepEnd} | ||
| beginBuildStep "Building Image ${SERVICE_NAME}" "buildingImage${SERVICE_NAME_TITLE}" |
There was a problem hiding this comment.
Is having each buildstep for each image (and push images) individually named going to make it harder to track and compare historic statistics ie
lagoon.sh/buildStep=buildingImageweb and lagoon.sh/buildStep=pushingImagemongo-4
Is there a way to maintain the current buildingImages step as a wrapper for all images, and still track the individuals?
There was a problem hiding this comment.
Maybe. However, build steps are not something that should be relied on for statistics as they are always subject to change being a free text field and not an actual build status like complete etc..
If we want to enforce these as a method for statistics, we should define what this statistical analysis methods should look like, and it should be saved in the API as a separate array field in a deployment, rather than as arbitrary labels on deployments.
There was a problem hiding this comment.
yah - fair point - happy to retire this suggestion, but maybe a suggestion here just to split the step and service names with a _ or - for clarity (and same in pushingImage)
| beginBuildStep "Building Image ${SERVICE_NAME}" "buildingImage${SERVICE_NAME_TITLE}" | |
| beginBuildStep "Building Image ${SERVICE_NAME}" "buildingImage_${SERVICE_NAME_TITLE}" |
There was a problem hiding this comment.
These unfortunately have to somewhat conform with status conditions in kubernetes/remote-controller
We'd need to update the remote-controller to transform these if we include - or _ in the build-deploy-tool. I'm happy to do this, but it would delay this PR.
There was a problem hiding this comment.
ah - ok for now then - but given a service name with a - in it, it does come out like so lagoon.sh/buildStep=pushingImagemongo-4 - is that likely to break anything?
There was a problem hiding this comment.
:hidethepain: maybe
There was a problem hiding this comment.
Keep this one on hold, maybe we put it for 2.24 instead with a slight revisit.
Splits image build and pushes into individual steps where possible to aid in providing more up to date build logs, and help identify where slowness could be occurring during builds.