Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds more environment variable control #16

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Conversation

bomoko
Copy link
Collaborator

@bomoko bomoko commented Nov 23, 2023

In order to bring the service closer in line with the 12 factor app philosophy on configuration, this PR introduces better environment variable control over insights-remote.

@bomoko bomoko requested a review from shreddedbacon November 23, 2023 18:43
Copy link
Member

@shreddedbacon shreddedbacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

@bomoko bomoko merged commit a5221c5 into main Nov 23, 2023
2 checks passed
@bomoko bomoko deleted the feature/better-env-vars branch February 25, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants