Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constraining incoming CM types #20

Merged
merged 6 commits into from
Mar 4, 2024
Merged

Constraining incoming CM types #20

merged 6 commits into from
Mar 4, 2024

Conversation

bomoko
Copy link
Collaborator

@bomoko bomoko commented Feb 25, 2024

This PR is related to #19 - it does part of the work here to constrain outgoing configMap insights to only those currently added by the build-deploy-tool.

Anything that isn't able to be determined to be precisely an inspect or sbom type, either by inferrence (to support previous versions of the build-deploy tool), or explicitly typed as such with the insights.lagoon.sh/type label, are rejected.

@bomoko bomoko requested a review from shreddedbacon February 26, 2024 00:08
@bomoko bomoko marked this pull request as ready for review February 26, 2024 00:09
Copy link
Member

@shreddedbacon shreddedbacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@bomoko bomoko merged commit 92a98c3 into main Mar 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants