-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Lagoon charts for Kubernetes 1.22 (min version now 1.19) #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smlx
approved these changes
May 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The chart changes LGTM. 1.0.0 🎉
smlx
requested changes
May 3, 2022
smlx
approved these changes
May 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tobybellwood
changed the title
needed chart updates for Kubernetes 1.22 only
Update Lagoon charts for Kubernetes 1.22 (min version now 1.19)
Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the ingresses, hpas and priorityclasses in preparation for Kubernetes 1.22. As these changes are only compatible with Kubernetes 1.19 onwards, the kubeVersion constraint has been added to the chart.yaml
In addition, the lagoon-gatekeeper chart release 0.4.0 has been marked as deprecated, and only compatible with <1.22
This PR also disables linting for the lagoon-gatekeeper chart and lagoon-insights-remote (as it needs remediation to start successfully without a broker present (uselagoon/insights-remote#2)
Note that the ingresses and priorityclasses have already been auto-patched to their GA versions by Kubernetes on install, so this is mostly a tidyup to remove the deprecation notices.
In this PR, I have only migrated lagoon-core to a major version, as that is the primary chart for Lagoon (and also where the most change is occurring). We can mark Lagoon-remote as 1.0 after the dependent charts are updated,