Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Lagoon charts for Kubernetes 1.22 (min version now 1.19) #417

Merged
merged 24 commits into from
Jun 6, 2022

Conversation

tobybellwood
Copy link
Member

@tobybellwood tobybellwood commented Apr 5, 2022

This PR updates the ingresses, hpas and priorityclasses in preparation for Kubernetes 1.22. As these changes are only compatible with Kubernetes 1.19 onwards, the kubeVersion constraint has been added to the chart.yaml

In addition, the lagoon-gatekeeper chart release 0.4.0 has been marked as deprecated, and only compatible with <1.22

This PR also disables linting for the lagoon-gatekeeper chart and lagoon-insights-remote (as it needs remediation to start successfully without a broker present (uselagoon/insights-remote#2)

Note that the ingresses and priorityclasses have already been auto-patched to their GA versions by Kubernetes on install, so this is mostly a tidyup to remove the deprecation notices.

In this PR, I have only migrated lagoon-core to a major version, as that is the primary chart for Lagoon (and also where the most change is occurring). We can mark Lagoon-remote as 1.0 after the dependent charts are updated,

@tobybellwood tobybellwood marked this pull request as ready for review April 8, 2022 03:04
@tobybellwood tobybellwood requested a review from smlx April 8, 2022 03:04
Copy link
Member

@smlx smlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The chart changes LGTM. 1.0.0 🎉

.github/workflows/lint-test.yaml Outdated Show resolved Hide resolved
.github/workflows/lint-test.yaml Outdated Show resolved Hide resolved
@tobybellwood tobybellwood requested a review from smlx May 20, 2022 01:50
Copy link
Member

@smlx smlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tobybellwood tobybellwood changed the title needed chart updates for Kubernetes 1.22 only Update Lagoon charts for Kubernetes 1.22 (min version now 1.19) Jun 6, 2022
@tobybellwood tobybellwood merged commit 40ed873 into main Jun 6, 2022
@tobybellwood tobybellwood deleted the k8s122_chart_updates branch June 6, 2022 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants