chore: add clusterroles for tasks and builds to admin and edit #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreddedbacon
force-pushed
the
build-deploy-cluster-role
branch
from
8e75d2c to
791d520
Compare
|
It would be nice to get this into a lagoon-remote update as part of lagoon-remote 0.87.0 in the 2.17 branch |
tobybellwood
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just adding the missing clusterroles to the admin role to allow the lagoon namespace deployer service account to interact with builds and tasks within the namespace as required
Currently the deployer service account can interact with all other resources within the namespace during a build, and being able to interact with other builds or tasks that may exist in the namespace would be useful for being able to handle previous build or task cleanups within a build process.