feat: support for static hostkeys in ssh core #678
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreddedbacon
force-pushed
the
core-ssh-hostkeys
branch
5 times, most recently
from
a1b60f5 to
7f35114
Compare
shreddedbacon
force-pushed
the
core-ssh-hostkeys
branch
3 times, most recently
from
ce80bd9 to
19fda14
Compare
shreddedbacon
force-pushed
the
core-ssh-hostkeys
branch
from
19fda14 to
dec692d
Compare
|
closed as part of #679 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSH portal allows for keys to be defined for host key verification. Lagoon-core SSH service does not and randomly generates a new key each time, this provides a bad experience and forces users to ignore the host key checks.
This change allows for keys to be defined on the core service now.
The core ssh service defines has the following https://github.com/uselagoon/lagoon/blob/2b4283b707a74b8d677c6f32d595fbcf51e613fb/services/ssh/etc/ssh/sshd_config#L3-L5
If they're not provided by the chart, then the core service will generate them each time a pod restarts (not ideal)
closes #655