chore: refactor unsafe regex for easier reuse

uselagoon · Feb 22, 2024 · b97db9c · b97db9c
1 parent af8dcdf
commit b97db9c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/cmd/helpers.go b/cmd/helpers.go
@@ -10,13 +10,11 @@ import (
 	"github.com/spf13/pflag"
 )
 
+var unsafeRegex = regexp.MustCompile(`[^0-9a-z-]`)
+
 // makeSafe ensures that any string is dns safe
 func makeSafe(in string) string {
-	out := regexp.MustCompile(`[^0-9a-z-]`).ReplaceAllString(
-		strings.ToLower(in),
-		"$1-$2",
-	)
-	return out
+	return unsafeRegex.ReplaceAllString(strings.ToLower(in), "$1-$2")
 }
 
 // shortenEnvironment shortens the environment name down the same way that Lagoon does

diff --git a/cmd/helpers_test.go b/cmd/helpers_test.go
@@ -24,6 +24,11 @@ func Test_makeSafe(t *testing.T) {
 			in:   "Feature-Branch",
 			want: "feature-branch",
 		},
+		{
+			name: "space in name",
+			in:   "My Project",
+			want: "my-project",
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {