-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for streaming container logs from services #285
Conversation
This would be amazing, several customers have mentioned that having to wait for ElasticSearch to have logs can be 30-60 seconds delay, and the logs can be out of order. Having more real time logs, in the correct order would be ace. |
It is coming, just need support for the feature in the charts. |
The only thing I wanted to verify before merging this was the error someone would get if the ssh-portal does not have support for
I'm not sure if there is a better way to determine if the logs endpoint is just disabled or not though from the error, as this gives the impression that the SSH service has an issue, but using |
I can update the default return message for the |
Checklist
This PR adds support for this new log access feature in ssh-portal: uselagoon/lagoon-ssh-portal#243
It allows you to access container logs from any Lagoon environment that you have permission to SSH to, via the command line.
The command can either collect existing logs, or "follow" live logs via
-f
.Please do not merge this until uselagoon/lagoon-ssh-portal#243 is merged, and lagoon-charts is updated to a version with this feature.
Changelog Entry
Feature - access logs from the CLI (#232)
Closing issues
Closes: #232