Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support the new idle labels and annotations #459

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Conversation

smlx
Copy link
Member

@smlx smlx commented Jul 12, 2024

The idle labels and annotations can now have the lagoon.sh suffix as
amazee.io.

This change adds support for both suffixes, with idling.lagoon.sh taking
priority over idling.amazee.io.

Closes: #458

@smlx smlx marked this pull request as draft July 12, 2024 08:22
@smlx
Copy link
Member Author

smlx commented Jul 12, 2024

Leaving this as a draft until uselagoon/aergia-controller#31 is merged.

@smlx smlx force-pushed the idling-annotations branch from 059f66f to ebfda0c Compare July 12, 2024 08:28
@shreddedbacon
Copy link
Member

This should be good now, the main core PR has been merged now

@smlx smlx force-pushed the idling-annotations branch from ebfda0c to cd6bda7 Compare September 27, 2024 09:41
@smlx smlx marked this pull request as ready for review September 27, 2024 09:41
The idle labels and annotations can now have the lagoon.sh suffix as
amazee.io.

This change adds support for both suffixes, with idling.lagoon.sh taking
priority over idling.amazee.io.
@smlx smlx force-pushed the idling-annotations branch from cd6bda7 to 9a376b8 Compare October 4, 2024 03:32
@smlx smlx merged commit c0c0e1b into main Oct 4, 2024
12 checks passed
@smlx smlx deleted the idling-annotations branch October 4, 2024 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aergia idling label and annotation changes
2 participants