Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task cancellations in the UI #164

Merged
merged 9 commits into from
Oct 11, 2023
Merged

add task cancellations in the UI #164

merged 9 commits into from
Oct 11, 2023

Conversation

DaveDarsa
Copy link
Contributor

Ability to cancel tasks in the ui tasks page and individual task page

closes: #137

@shreddedbacon
Copy link
Member

shreddedbacon commented Sep 17, 2023

image
I like how this adds the cancellation button to the overview list for tasks.

Would it be possible to also do this on the deployments list?

The > in the table row probably doesn't need to exist in either tables too, it seems irrelevant

@DaveDarsa
Copy link
Contributor Author

Sure thing 👍

@tobybellwood tobybellwood added this to the 2.16.x milestone Oct 3, 2023
@tobybellwood
Copy link
Member

Looks good, and works as expected - two minor nits on the error display when trying to cancel without permissions:
Screenshot from 2023-10-05 10-29-23
Screenshot from 2023-10-05 10-39-42

@DaveDarsa
Copy link
Contributor Author

Screenshot 2023-10-10 at 10 42 53 AM @tobybellwood I think instead of cramming the error in the table, there should be an error notification like so

@tobybellwood
Copy link
Member

There's also the cancel deployment error that inlines (even worse than tasks) @DaveDarsa ?

@DaveDarsa
Copy link
Contributor Author

@tobybellwood should be good to go

@tobybellwood tobybellwood merged commit 3f44038 into main Oct 11, 2023
2 checks passed
@tobybellwood tobybellwood deleted the task-cancellations branch October 11, 2023 04:46
@shreddedbacon
Copy link
Member

shreddedbacon commented Oct 11, 2023

Does this error popup change all errors to this? Or just tasks/deployments?

@DaveDarsa
Copy link
Contributor Author

@shreddedbacon just tasks/task/deployments/deployment cancel buttons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to cancel tasks
3 participants