Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds cypress to the UI #184

Closed
wants to merge 42 commits into from
Closed

adds cypress to the UI #184

wants to merge 42 commits into from

Conversation

DaveDarsa
Copy link
Contributor

No description provided.

@DaveDarsa
Copy link
Contributor Author

@tobybellwood @bomoko

to run locally/ci a couple env vars are needed: CY_EMAIL CY_PASSWORD CY_URL CY_KEYCLOAK_URL CY_API

in the terminal
CYPRESS_CY_EMAIL=userEmail CYPRESS_CY_PASSWORD=password CYPRESS_CY_URL="localhost:3003 for local dev" CYPRESS_CY_KEYCLOAK_URL="..." CYPRESS_CY_API="..." npx cypress open

couple things that need to be fixed:

  • the organization id and name are hardcoded (preferable to use an env var)

  • project name is also hardcoded

  • some of the tests are failing but it shouldn't be the case if we don't run it against test6.

  • some tests are timing out (which I'll fix)

@bomoko
Copy link
Contributor

bomoko commented Oct 30, 2023

This is looking very good @DaveDarsa! Thanks so much for this work.

I'm doing a pretty detailed review/test of what's here atm, but a general nit about test names - I think it's important that we use the BDD style names where possible - so, for instance, it('Add/update a variable', should read something like it('should add or update a variable',

With test names I reckon we be as explicit and verbose as we need to be with describing precisely what the test is up to.

(more comments incoming as I dig :) )

cypress/e2e/environment.cy.ts Outdated Show resolved Hide resolved
cypress/e2e/environment.cy.ts Outdated Show resolved Hide resolved
cypress/e2e/navigation.cy.ts Outdated Show resolved Hide resolved
cypress/support/actions/organizations/GroupsAction.ts Outdated Show resolved Hide resolved
cypress/e2e/organizations/groups.cy.ts Outdated Show resolved Hide resolved
cypress/e2e/organizations/navigation.cy.ts Outdated Show resolved Hide resolved
cypress/e2e/sidebarNav.cy.ts Outdated Show resolved Hide resolved
cypress/fixtures/example.json Outdated Show resolved Hide resolved
@DaveDarsa DaveDarsa requested a review from bomoko November 5, 2023 18:22
@DaveDarsa DaveDarsa marked this pull request as ready for review November 5, 2023 18:22
@DaveDarsa DaveDarsa changed the title first pass at adding cypress to the UI adds cypress to the UI Nov 5, 2023
@DaveDarsa
Copy link
Contributor Author

to run/open locally: yarn cypress:run or yarn cypress:open

to run in ci:

  1. cd test && make up
  2. yarn build && GRAPHQL_API=http://0.0.0.0:33000/graphql KEYCLOAK_API=http://0.0.0.0:38088/auth yarn start
  3. yarn cypress:run

@tobybellwood tobybellwood added this to the 2.18.x milestone Feb 16, 2024
@tobybellwood
Copy link
Member

This is looking really good - but lets go through and maybe redo into fewer commits - one for cypress, one for the fixups needed for cypress, and one for the github action, just to reduce some of the noise?

This was referenced Feb 29, 2024
@DaveDarsa DaveDarsa closed this Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants