-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds cypress to the UI #184
Conversation
to run locally/ci a couple env vars are needed: in the terminal couple things that need to be fixed:
|
This is looking very good @DaveDarsa! Thanks so much for this work. I'm doing a pretty detailed review/test of what's here atm, but a general nit about test names - I think it's important that we use the BDD style names where possible - so, for instance, With test names I reckon we be as explicit and verbose as we need to be with describing precisely what the test is up to. (more comments incoming as I dig :) ) |
Lagoon minimal
to run/open locally: to run in ci:
|
merge into cypress
This is looking really good - but lets go through and maybe redo into fewer commits - one for cypress, one for the fixups needed for cypress, and one for the github action, just to reduce some of the noise? |
No description provided.