Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use compose from uselagoon/lagoon #266

Merged
merged 4 commits into from
Oct 15, 2024
Merged

refactor: use compose from uselagoon/lagoon #266

merged 4 commits into from
Oct 15, 2024

Conversation

shreddedbacon
Copy link
Member

@shreddedbacon shreddedbacon commented Jun 23, 2024

Remove the snowflake docker-compose test stack to use an upstream uselagoon/lagoon make command for better support of a testing stack

@shreddedbacon shreddedbacon force-pushed the core-api branch 6 times, most recently from d4afb43 to 4400d6f Compare June 24, 2024 00:32
@shreddedbacon
Copy link
Member Author

shreddedbacon commented Jun 24, 2024

Not sure why the lint fails, I haven't changed anything that is complaining about, but I noticed that #260 was working, and is now no longer working. The only change I can see is that the underlying github runner image changed versions so 🤷

@shreddedbacon shreddedbacon force-pushed the core-api branch 8 times, most recently from 4881fc7 to bf418d1 Compare June 25, 2024 07:14
@shreddedbacon
Copy link
Member Author

Leave this one alone for now, this won't be merged anytime soon probably because there is an upstream change in uselagoon/lagoon that this depends on that needs to be decided on first.

@shreddedbacon shreddedbacon force-pushed the core-api branch 5 times, most recently from b6de2ad to fe747b2 Compare July 8, 2024 00:52
@shreddedbacon shreddedbacon force-pushed the core-api branch 6 times, most recently from bb664ae to fa6dbe2 Compare September 16, 2024 00:51
@shreddedbacon shreddedbacon marked this pull request as ready for review October 14, 2024 22:30
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@tobybellwood tobybellwood merged commit 14fc1f7 into main Oct 15, 2024
4 checks passed
@tobybellwood tobybellwood deleted the core-api branch October 15, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants