Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: show count on system groups/users and toggle users on by default #284

Merged
merged 5 commits into from
Jul 11, 2024

Conversation

DaveDarsa
Copy link
Contributor

@DaveDarsa DaveDarsa commented Jul 8, 2024

closes #270

@DaveDarsa DaveDarsa requested a review from shreddedbacon July 8, 2024 10:23
@shreddedbacon
Copy link
Member

On organizations/${org}/users "Show default users" should be unticked by default. If the count of non default users is 0, then it should be ticked.

On organizations/${org}/users/${emailaddress} "Show system groups" should be unticked by default. If the count of non system groups is 0, then it should be ticked.

On organizations/${org}/projects/${projectname} "Show system groups" should be unticked by default. If the count of non system groups is 0, then it should be ticked.

On organizations/${org}/groups/${groupname} "Show default users" should be unticked by default. If the count of non default users is 0, then it should be ticked.

@shreddedbacon
Copy link
Member

The count shown in the tick box label is great though!

@shreddedbacon
Copy link
Member

On organizations/${org}/groups/${groupname}, the list of projects has a tick box to Show system groups. But this isn't required on this table, projects are just projects
image

Copy link
Member

@shreddedbacon shreddedbacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

@DaveDarsa DaveDarsa merged commit 3a04fce into main Jul 11, 2024
4 checks passed
@DaveDarsa DaveDarsa deleted the system-default-count branch July 11, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If a user is only in "system" groups, the UI should handle this
2 participants