Merge pull request #3734 from uselagoon/environment-exists-validator

fix: actually throw error in environmentExists if the environment doesn't exist
uselagoon · Jun 7, 2024 · 8ef9eac · 8ef9eac
2 parents 871dee3 + 1e1b3e6
commit 8ef9eac
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/services/api/src/resources/environment/validators.ts b/services/api/src/resources/environment/validators.ts
@@ -10,8 +10,9 @@ export const Validators = (sqlClientPool: Pool) => ({
       Sql.selectEnvironmentById(environmentId)
     );
 
-    if (R.has('info', env)) {
-      throw new Error(`Environment ID ${environmentId} doesn't exist.`);
+    if (R.length(env) == 0) {
+      // environment doesn't exist, throw an unauthorized error
+      throw new Error(`Unauthorized: You don't have permission to "view" on "environment"`);
     }
   },
   environmentsHaveSameProject: async (environmentIds: number[]) => {