Merge pull request #3719 from uselagoon/refactor-group-membercount

refactor: use existing cached member check to return membercount
uselagoon · May 7, 2024 · b470e13 · b470e13
2 parents 18d528a + ab7e574
commit b470e13
Showing 1 changed file with 2 additions and 10 deletions.
diff --git a/services/api/src/models/group.ts b/services/api/src/models/group.ts
@@ -539,16 +539,8 @@ export const Group = (clients: {
   const getGroupMemberCount = async (
     group: Group
   ): Promise<number> => {
-    const roleSubgroups = group.subGroups.filter(isRoleSubgroup);
-    let membership = 0;
-    for (const roleSubgroup of roleSubgroups) {
-      const keycloakUsers = await keycloakAdminClient.groups.listMembers({
-        id: roleSubgroup.id
-      });
-
-      membership = membership + keycloakUsers.length;
-    }
-    return membership;
+    const membership = await getGroupMembership(group)
+    return membership.length;
   };
 
   const addGroup = async (groupInput: Group, projectId?: number, organizationId?: number): Promise<Group> => {