Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change: Updated argument naming organizationByID #3562

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Change: Updated argument naming organizationByID #3562

merged 3 commits into from
Oct 10, 2023

Conversation

CGoodwin90
Copy link
Contributor

@CGoodwin90 CGoodwin90 commented Oct 9, 2023 •
edited
Loading

General Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for inclusion in changelog

Updates the argument naming from organization to id for the organizationByID resolver.

To be merged alongside UI PR uselagoon/lagoon-ui#170

@CGoodwin90 CGoodwin90 mentioned this pull request Oct 9, 2023
Merged
@CGoodwin90 CGoodwin90 changed the title Updated argument naming organizationByID Change: Updated argument naming organizationByID Oct 9, 2023
@CGoodwin90 CGoodwin90 marked this pull request as ready for review October 10, 2023 06:35
shreddedbacon
shreddedbacon approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@shreddedbacon shreddedbacon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an input name change to id, makes sense. Since organizations isn't released yet, so this isn't breaking

@tobybellwood tobybellwood merged commit 06f6da1 into main Oct 10, 2023
@tobybellwood tobybellwood deleted the organizationById_update branch October 10, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreddedbacon shreddedbacon shreddedbacon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CGoodwin90 @shreddedbacon @tobybellwood