Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate activeSystems* in API #3647

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Deprecate activeSystems* in API #3647

merged 2 commits into from
Mar 15, 2024

Conversation

rocketeerbkw
Copy link
Member

General Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for inclusion in changelog

Database Migrations

  • If your PR contains a database migation, it MUST be the latest in date order alphabetically

Lagoon has not supported multiple "activeSystems*" for quite some time. This PR removes all logic tied to their data and marks the fields deprecated in the API.

Closing issues

n/a

@shreddedbacon
Copy link
Member

Probably just add a deprecation notice in the DEPRECATIONS.md, use 2.18.0 for now similarly to #3618 and we can work out merge conflicts when it comes time to merge

@shreddedbacon shreddedbacon added this to the 2.18.0 milestone Feb 5, 2024
@rocketeerbkw
Copy link
Member Author

The tests are failing at the same spot, so not a transient testing issue.

shreddedbacon
shreddedbacon requested changes Feb 12, 2024
View reviewed changes
node-packages/commons/src/tasks.ts Outdated Show resolved Hide resolved
node-packages/commons/src/tasks.ts Show resolved Hide resolved
@shreddedbacon shreddedbacon removed this from the 2.18.0 milestone Feb 26, 2024
@rocketeerbkw rocketeerbkw force-pushed the deprecate-activesystems branch from da8f530 to ea8e158 Compare March 12, 2024 20:55
@rocketeerbkw rocketeerbkw force-pushed the deprecate-activesystems branch from ea8e158 to 945437c Compare March 13, 2024 02:49
@rocketeerbkw
Copy link
Member Author

🙏 to the test Gods

@tobybellwood tobybellwood added this to the 2.18.0 milestone Mar 13, 2024
@shreddedbacon shreddedbacon self-requested a review March 13, 2024 20:54
shreddedbacon
shreddedbacon approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@shreddedbacon shreddedbacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Especially like the cleanup done in api.ts to remove all the unused functions 🚀

Not fully wrapped my head around typescript Pick<>, but reading about how it works makes sense.

@tobybellwood tobybellwood merged commit 3a87f84 into main Mar 15, 2024
2 checks passed
@tobybellwood tobybellwood deleted the deprecate-activesystems branch March 25, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreddedbacon shreddedbacon shreddedbacon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.18.0
Development

Successfully merging this pull request may close these issues.
3 participants
@rocketeerbkw @shreddedbacon @tobybellwood