-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use api-sidecar-handler to offload sshkey handling and add more types #3662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreddedbacon
force-pushed
the
sshkey-handler
branch
2 times, most recently
from
March 4, 2024 07:13
94ab4b1
to
30ae6c7
Compare
shreddedbacon
force-pushed
the
sshkey-handler
branch
2 times, most recently
from
April 2, 2024 23:42
a277940
to
efa31cc
Compare
shreddedbacon
force-pushed
the
sshkey-handler
branch
from
May 28, 2024 04:34
efa31cc
to
70034b7
Compare
shreddedbacon
force-pushed
the
sshkey-handler
branch
from
June 5, 2024 22:34
70034b7
to
35aaa3e
Compare
tobybellwood
changed the title
feat: use sshkey-handler to allow for more sshkey types
feat: use api-sidecar-handler to offload sshkey handling and add more types
Jun 13, 2024
tobybellwood
force-pushed
the
sshkey-handler
branch
from
June 18, 2024 22:17
35aaa3e
to
ddc79c8
Compare
shreddedbacon
force-pushed
the
sshkey-handler
branch
2 times, most recently
from
June 25, 2024 01:55
561a13a
to
07b4df9
Compare
shreddedbacon
force-pushed
the
sshkey-handler
branch
from
June 30, 2024 22:24
07b4df9
to
62b8aa8
Compare
shreddedbacon
force-pushed
the
sshkey-handler
branch
from
June 30, 2024 23:42
d046683
to
0435a22
Compare
shreddedbacon
force-pushed
the
sshkey-handler
branch
from
July 1, 2024 01:09
0435a22
to
973a36c
Compare
tobybellwood
reviewed
Jul 2, 2024
services/api/database/migrations/20240730000000_sshkey_types.js
Outdated
Show resolved
Hide resolved
tobybellwood
approved these changes
Jul 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TEsted thoroughly and nits worked out. Good to go
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General Checklist
Database Migrations
The node package
sshpk
doesn't support all the various key types out there. The aim of this PR is to introduce a sidecar to required services that runs a simple http server that can replace the functionality of thesshpk
package.Each
api
andwebhooks2tasks
pod will get this sidecar so that they aren't reliant on a single service for this functionality, and as there is no state it doesn't need to be a single service and fits nicely as a sidecar.It introduces new APIs to interact with user ssh keys that doesn't require the user to define the type independently. The input is just
publicKey
which can be the fullssh-ed25519 A....z
format public key (including comment). The database table for the type is also converted fromenum
tostring
to support any new types, and since the older APIs had enum enforcement, that still applies for anyone that uses the older APIs.The old APIs remain for now, but have been flagged as deprecated. They will be removed in a future release to give time for tooling and UI to be updated to use the newer APIs.
New mutation examples
Add public key
Update public key
Delete public key
Closing issues
closes #2189
closes #1584
addresses #2384 by deprecating
deleteSshKey
which takes thename
input