Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Implements getNotificationByNameAndType #3669

Closed
wants to merge 5 commits into from

Conversation

CGoodwin90
Copy link
Contributor

@CGoodwin90 CGoodwin90 commented Mar 7, 2024

Implements getNotificationByNameAndType allowing for a notification to be retreived by its name and type. Retreives both unassigned & assigned notifications.

@CGoodwin90 CGoodwin90 changed the title WIP: Implements getNotificationByNameAndType Implements getNotificationByNameAndType Mar 19, 2024
@CGoodwin90 CGoodwin90 marked this pull request as ready for review March 20, 2024 00:57
@CGoodwin90 CGoodwin90 changed the title Implements getNotificationByNameAndType Feature: Implements getNotificationByNameAndType Apr 10, 2024
@tobybellwood tobybellwood added this to the 2.20.0 milestone May 30, 2024
@shreddedbacon
Copy link
Member

shreddedbacon commented Jun 12, 2024

I'm wondering if this is required or not now. Was there a reason for its need?

I'm wondering if allNotifications in #3671 could be extended to have an optional name input and omit the type input entirely? (or leave type too, and handle the permissions the same way this does)

@CGoodwin90
Copy link
Contributor Author

I'm wondering if this is required or not now. Was there a reason for its need?

I'm wondering if allNotifications in #3671 could be extended to have an optional name input and omit the type input entirely? (or leave type too, and handle the permissions the same way this does)

No specific usecase, it was purely so we had some way to get the unassigned notifcations lost to the void. I like the idea of extending allNotifications to support the optional name, I can pull something together.

@CGoodwin90
Copy link
Contributor Author

Closing, replaced by #3740

@CGoodwin90 CGoodwin90 closed this Jun 13, 2024
@shreddedbacon shreddedbacon deleted the get-notification-by-name branch September 18, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants