Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Remove Harbor Trivy integration from Lagoon Core. #3672

Merged
merged 7 commits into from
Mar 15, 2024

Conversation

bomoko
Copy link
Contributor

@bomoko bomoko commented Mar 8, 2024

This PR removes Trivy integration in core - since Harbor is no longer part of Lagoon core, and Insights has now taken the place of generating SBOM scan results.

It does the following:

  • Removes the tables and code for harbor scan matches
  • Deprecates calls in the GraphQL schema for the above
  • Adds exceptions when these GraphQL endpoints are called
  • Removes all webhook integrations and tests for Trivy payloads

Closes #3082

@bomoko bomoko requested a review from tobybellwood March 10, 2024 16:47
@tobybellwood tobybellwood added this to the 2.18.0 milestone Mar 13, 2024
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, a neat and tidy excision of code that's no longer functional

@tobybellwood tobybellwood merged commit 0c024db into main Mar 15, 2024
2 checks passed
@tobybellwood tobybellwood deleted the chore/remove_harbor_from_core branch March 25, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Insights version 2 work - remove Lagoon Core Harbor/Trivy/Drutiny integration
2 participants