Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecation: delete backups when they are deleted #3679

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

shreddedbacon
Copy link
Member

General Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for inclusion in changelog

Database Migrations

  • If your PR contains a database migation, it MUST be the latest in date order alphabetically

Deleted backups remain in the API DB, though there is no method of recovering from a backup that is deleted. It makes little sense to retain backups that are deleted in this case.

This announces the deprecation of deleted backups, and includes a migration that will remove deleted backups from the database.

Additionally, the includeDeleted option when querying backups will now do nothing, this will be removed in a future release.

Sorry, something went wrong.

@shreddedbacon shreddedbacon changed the title refactor: delete backups when they are deleted deprecation: delete backups when they are deleted Mar 14, 2024
@tobybellwood tobybellwood added this to the 2.19.0 milestone Mar 14, 2024
@tobybellwood tobybellwood modified the milestones: 2.19.0, 2.20.0 May 14, 2024
@shreddedbacon shreddedbacon force-pushed the deprecate-deleted-backups branch 2 times, most recently from 53c601a to 85aacb5 Compare June 6, 2024 23:58
@shreddedbacon shreddedbacon marked this pull request as ready for review June 7, 2024 00:01
@shreddedbacon shreddedbacon force-pushed the deprecate-deleted-backups branch from 85aacb5 to ec08476 Compare June 7, 2024 06:54
@shreddedbacon shreddedbacon force-pushed the deprecate-deleted-backups branch from ec08476 to ab7caf5 Compare June 25, 2024 01:55
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as expected, cleans up the db nicely.

@tobybellwood tobybellwood merged commit 14f5c2a into main Jun 26, 2024
3 checks passed
@shreddedbacon shreddedbacon deleted the deprecate-deleted-backups branch June 26, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants