Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: fixes migration deletion logic for duplicate environment_services #3705

Merged
merged 1 commit into from
Apr 5, 2024
Merged

FIX: fixes migration deletion logic for duplicate environment_services #3705

merged 1 commit into from
Apr 5, 2024

Conversation

bomoko
Copy link
Contributor

@bomoko bomoko commented Apr 4, 2024

This PR changes the logic of the existing migration (described in #3704 )
This fix is done in the actual migration because

  1. If the current migration has already been run, there is nothing for a brand new migration to do
  2. If the current migration hasn't been run, running it will cause data loss. We could no-op the existing migration, but that would just mean a second migration with complex logic to determine which version of the current migration (broken or no-op) had been run.

This closes #3704

@bomoko bomoko requested a review from shreddedbacon April 4, 2024 22:13
rocketeerbkw
rocketeerbkw approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@rocketeerbkw rocketeerbkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the new migration with the same data set that surfaced the issue and it's working as expected now.

@tobybellwood tobybellwood added this to the 2.18.1 milestone Apr 4, 2024
@tobybellwood tobybellwood merged commit 3da6b90 into main Apr 5, 2024
2 checks passed
@tobybellwood tobybellwood deleted the fix/service_environment_migration branch July 4, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rocketeerbkw rocketeerbkw rocketeerbkw approved these changes

@shreddedbacon shreddedbacon Awaiting requested review from shreddedbacon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.18.1
Development

Successfully merging this pull request may close these issues.

Database migration for environment_services table in 2.18.0 is too agressive.
3 participants
@bomoko @rocketeerbkw @tobybellwood