-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: change default quotas to unlimited for organizations #3720
Conversation
This makes sense. I was also wondering if we should or could make quota_environment a multiple of quota_project - you could end up creating an org with less envs than project limits. |
Yeah, I've thought about this too. But then I get into the "what if one project needs a higher env quota than another project?" and it just becomes a more complex quota solution. Something like default is |
For now, this PR is just to reset the route quota. We can discuss quota extensions/refactoring in a separate issue |
Updated this to reset all quotas for organizations. We will leave these at unlimited for now, but we will look to explore quota rulesets as a feature in the future for finer control over quotas. The default quotas will remain as they are for now as limits on overall resources (except routes) |
Another to add a created timestamp on the organization |
8e746f0
to
5b11bc8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes make sense.
General Checklist
Database Migrations
Just changes the route quota default to be unlimited by default.
This is mainly because currently the route quota can only be enforced per environment by the build process. With the default being 5, any builds would fail regularly if an environment has more than 5 routes, so when an organization is created, this consideration needs to be made.
Since most people probably wouldn't be doing any route enforcement, it makes more sense for now to make it unlimited and it can be used as required until a better solution can be found (routes in the API, other...)
Updated to include all quotas default to unlimited, this way when an organization is created there are no default limitations, but the creator of the organization has some ability to enforce things as required.
Also updated to include a created timestamp on organizations