Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update logs2notifications to use machinery #3792

Merged
merged 1 commit into from
Aug 18, 2024
Merged

chore: update logs2notifications to use machinery #3792

merged 1 commit into from
Aug 18, 2024

Conversation

shreddedbacon
Copy link
Member

General Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for inclusion in changelog

Database Migrations

  • If your PR contains a database migation, it MUST be the latest in date order alphabetically

Update logs2notifications to use machinery

Also include a bump in machinery version for actions-handler

Closing issues

partially #3783

@shreddedbacon shreddedbacon added this to the 2.21.0 milestone Aug 7, 2024
@shreddedbacon shreddedbacon force-pushed the logs2notifications-machinery branch from 960604f to e07a355 Compare August 14, 2024 01:01
@shreddedbacon shreddedbacon force-pushed the logs2notifications-machinery branch from e07a355 to 8fc17db Compare August 14, 2024 06:57
@shreddedbacon shreddedbacon marked this pull request as ready for review August 15, 2024 22:43
tobybellwood
tobybellwood approved these changes Aug 18, 2024
View reviewed changes
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks to work ok - have tested locally, and all notifications still create as they did

@tobybellwood tobybellwood merged commit 57b932e into main Aug 18, 2024
1 check passed
@tobybellwood tobybellwood deleted the logs2notifications-machinery branch August 18, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobybellwood tobybellwood tobybellwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.21.0
Development

Successfully merging this pull request may close these issues.
2 participants
@shreddedbacon @tobybellwood