chore: remove pendingmessage functionality #246
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
The pending messages functionality of the remote-controller never really worked well, and in clusters that typically do exhibit signs of queue instability the pending messages functionality didn't actually work in a lot of cases.
Rather than try and support a feature that adds additional complexity for not much gain, this PR is to remove it. It retains a command line flag but in a noop capacity, which should be removed in a future version.
The removal of this feature will mean that if there is a problem communicating back to rabbitmq during a build, that there is the possibility that the logs for the build may be lost, or the status of the build may be unknown. PR #224 also helped reduce the need for the pending messages check, along with older PRs that enhanced build cancellation functionality to attempt to retrieve the status of builds if a cancellation is received, #211 and associated PRS
Adjusting the flags
num-builds-to-keep
andnum-build-pods-to-keep
beyond the default of 1 can also help to retain logs longer in clusters that may exhibit communication issues with rabbitmq more frequently, but generally should not be required.