Skip to content

Commit

Permalink
refactor: renovate create memo
Browse files Browse the repository at this point in the history
  • Loading branch information
johnnyjoygh committed Feb 1, 2025
1 parent 98aa0b7 commit 97d12db
Show file tree
Hide file tree
Showing 6 changed files with 451 additions and 433 deletions.
20 changes: 8 additions & 12 deletions proto/api/v1/memo_service.proto
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ service MemoService {
rpc CreateMemo(CreateMemoRequest) returns (Memo) {
option (google.api.http) = {
post: "/api/v1/memos"
body: "*"
body: "memo"
};
}
// ListMemos lists memos with pagination and filter.
Expand Down Expand Up @@ -185,15 +185,8 @@ message Location {
}

message CreateMemoRequest {
string content = 1;

Visibility visibility = 2;

repeated Resource resources = 3;

repeated MemoRelation relations = 4;

optional Location location = 5;
// The memo to create.
Memo memo = 1 [(google.api.field_behavior) = REQUIRED];
}

message ListMemosRequest {
Expand Down Expand Up @@ -223,7 +216,9 @@ message GetMemoRequest {
}

message UpdateMemoRequest {
Memo memo = 1;
// The memo to update.
// The `name` field is required.
Memo memo = 1 [(google.api.field_behavior) = REQUIRED];

google.protobuf.FieldMask update_mask = 2;
}
Expand Down Expand Up @@ -285,7 +280,8 @@ message CreateMemoCommentRequest {
// The name of the memo.
string name = 1;

CreateMemoRequest comment = 2;
// The comment to create.
Memo comment = 2;
}

message ListMemoCommentsRequest {
Expand Down
Loading

0 comments on commit 97d12db

Please sign in to comment.