Skip to content

Commit

Permalink
remote/authenticator: drop obsolete ticket authenticator
Browse files Browse the repository at this point in the history
Now that labgrid-project#1079 and labgrid-project#1136 are merged, the coordinator no longer supports
ticket authentication. Drop the corresponding authenticator class, do
not advertise ticket auth anymore.

Exporters and clients might still talk to older coordinator versions, so
leave ticket authentication for these components enabled.

Signed-off-by: Bastian Krause <[email protected]>
  • Loading branch information
Bastian-Krause authored and Alexander Merkle committed Sep 8, 2023
1 parent d72f3a1 commit 3a3cff9
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 27 deletions.
20 changes: 0 additions & 20 deletions labgrid/remote/authenticator.py

This file was deleted.

5 changes: 1 addition & 4 deletions labgrid/remote/coordinator.py
Original file line number Diff line number Diff line change
Expand Up @@ -133,14 +133,11 @@ async def onConnect(self):
enable_tcp_nodelay(self)
self.join(
self.config.realm,
authmethods=["anonymous", "ticket"],
authmethods=["anonymous"],
authid="coordinator",
authextra={"authid": "coordinator"},
)

def onChallenge(self, challenge):
return "dummy-ticket"

@locked
async def onJoin(self, details):
await self.subscribe(self.on_session_join, 'wamp.session.on_join')
Expand Down
3 changes: 0 additions & 3 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -161,9 +161,6 @@ testpaths = [
]
addopts = "-p no:labgrid"

[tool.pylint.MASTER]
ignore-paths = ["labgrid/remote/authenticator.py"]

[tool.pylint.imports]
ignored-modules = ["gi"]

Expand Down

0 comments on commit 3a3cff9

Please sign in to comment.