mics secdist: prevent settings copy

userver-framework · May 8, 2024 · 05215b5 · 05215b5
1 parent f139635
commit 05215b5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/core/src/storages/secdist/default_provider.cpp b/core/src/storages/secdist/default_provider.cpp
@@ -123,7 +123,8 @@ void UpdateFromEnv(formats::json::Value& doc,
 
 }  // namespace
 
-DefaultProvider::DefaultProvider(Settings settings) : settings_{settings} {}
+DefaultProvider::DefaultProvider(Settings settings)
+    : settings_{std::move(settings)} {}
 
 formats::json::Value DefaultProvider::Get() const {
   auto doc =

diff --git a/core/src/storages/secdist/secdist_test.cpp b/core/src/storages/secdist/secdist_test.cpp
@@ -99,15 +99,13 @@ TEST(SecdistYamlConfig, Sample) {
       {std::make_unique<storages::secdist::DefaultProvider>(
           std::move(provider_settings))}};
 
-  /// [Secdist Usage Sample - SecdistConfig]
   const auto& user_passwords = secdist_config.Get<UserPasswords>();
 
   const auto password = UserPasswords::Password{"drowssap"};
   const auto another_password = UserPasswords::Password{"drowssap rehtona"};
   EXPECT_TRUE(user_passwords.IsMatching("username", password));
   EXPECT_FALSE(user_passwords.IsMatching("username2", password));
   EXPECT_TRUE(user_passwords.IsMatching("another username", another_password));
-  /// [Secdist Usage Sample - SecdistConfig]
 }
 
 UTEST(SecdistConfig, EnvironmentVariable) {