Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis standalone #822

Closed
Closed
Changes from 1 commit
Commits
Show all changes
56 commits
Select commit Hold shift + click to select a range
bb04c46
Standalone redis implementation
May 21, 2024
519a9ab
Configure 'send_readonly' flag
May 21, 2024
f87f94e
redis standalone functional testing
May 21, 2024
76ccf48
Fix build error (header)
May 21, 2024
0d7d66b
ES-29941: After update userver, add missing include for log
Jun 11, 2024
2094618
Fix integration test running
Sep 2, 2024
78520a2
Use correct pimpl in subscription mode
Sep 3, 2024
8930408
Testsuite for pub/sub standalone
Sep 3, 2024
c7b6e5e
Move redis standalone fixtures to plugin
Sep 3, 2024
98576c8
Redis standalne plugin moved for sharing
Sep 3, 2024
741942a
Move shared redis standalone plugin in integration_tests
Sep 3, 2024
b7f2960
Merge commit 'c2f43b4e' into redis_standalone_3
Jan 6, 2025
2a43580
Use redis::RedisCreationSettings from outside
Oct 28, 2024
2672989
Remove unused variable
Nov 24, 2024
7f1b3ce
Merge remote-tracking branch 'ya/develop' into develop
Nov 29, 2024
c32a353
Merge remote-tracking branch 'upstream/develop' into develop
Dec 26, 2024
56b981c
Merge commit '14570b32' into redis_standalone_3
Jan 6, 2025
7cf5015
Fix namespace for key standalone
Dec 26, 2024
c26ca88
Fix namespace
Dec 27, 2024
5904031
added empty SetConnectionInfo for standalone impl
Dec 27, 2024
09ce128
Merge branch 'gh_dev' into redis_standalone_3
Jan 6, 2025
df2b628
Minor namespace fixes and warnings
Jan 6, 2025
6a79fee
Redis standalone plugin moved to pytest_userver.plugins
Jan 7, 2025
c6bbc7a
Cosmetics
Jan 7, 2025
26d4133
Do not specify PYTHONPATH for pubsub testsuite
Jan 7, 2025
87c35a0
Run redis standalone the same way as in ya testsuites
Jan 7, 2025
e1af661
Rename redis_standalone.py -> pytest_plugin.py
Jan 7, 2025
6336dcc
Do not take into account pytest config
Jan 7, 2025
0864b9a
Use pragma
Jan 7, 2025
88c4f68
Cosmetics
Jan 7, 2025
19b2cf1
Fix metrics for standalone impl
Jan 7, 2025
cb59bb2
Formattings
Jan 7, 2025
6670e47
Added TopologyHolderBase interface
Jan 11, 2025
ae8bfe4
StandaloneTopologyHolder implementation
Jan 12, 2025
87ecd94
Construct correct topology holder
Jan 12, 2025
3966234
IsClusterStrategy is part of KeyShardFactory
Jan 12, 2025
4e16a39
Remove StandaloneImpl
Jan 12, 2025
822ebc2
Revert RedisCreationSettings changes
Jan 12, 2025
b519df3
Start watcher signal
Jan 12, 2025
059e562
Revert "Revert RedisCreationSettings changes"
Jan 12, 2025
43835f7
Do not send readonly
Jan 12, 2025
0801331
Implement SetConnectionInfo
Jan 13, 2025
f007fc7
Move StandaloneTopologyHolder to separate file
Jan 13, 2025
1e615be
Lock node creation process
Jan 14, 2025
2e17414
is_nodes_received_ flag
Jan 14, 2025
ee3f72c
Build topology based on null check
Jan 15, 2025
887bd4a
Nodes received if the same info
Jan 15, 2025
c59e855
Remove logs
Jan 15, 2025
ba429a8
Merge remote-tracking branch 'gh/develop' into redis_standalone
Jan 15, 2025
3d95f79
Remove unnecessary forward declaration
Jan 17, 2025
c970a0d
Remove unnecessary header
Jan 17, 2025
82f1b84
Remove todo
Jan 17, 2025
3692208
Formatting
Jan 17, 2025
c93aacf
Type of conn_to_create_ is ConnectionInfoInt
Feb 8, 2025
955e91c
Merge remote-tracking branch 'gh/develop' into redis_standalone
Feb 8, 2025
b8cff3c
Update/Get password methods for standalone impl
Feb 9, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove todo
Aleksey Ignatiev committed Jan 17, 2025
commit 82f1b843fb584923e43c9a2cd6fd4c3de8bdb570
1 change: 0 additions & 1 deletion redis/src/storages/redis/impl/cluster_sentinel_impl.cpp
Original file line number Diff line number Diff line change
@@ -357,7 +357,6 @@ class ClusterTopologyHolder : public TopologyHolderBase,
sentinels_->SetConnectionInfo(info_array);
}

// TODO Should become virtual
static size_t GetClusterSlotsCalledCounter() { return cluster_slots_call_counter_.load(std::memory_order_relaxed); }

boost::signals2::signal<void(HostPort, Redis::State)>& GetSignalNodeStateChanged() override {