Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added implementation of negative number matching. #1914

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jurgenvinju
Copy link
Member

@jurgenvinju jurgenvinju commented Feb 7, 2024

@PaulKlint couldn't help it. This can wait until we find it a good moment. The implementation is very simply to check if the subject is a negative number or not.

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (8e0f7b2) 49% compared to head (7a13680) 49%.

Files Patch % Lines
...ascalmpl/interpreter/matching/NegativePattern.java 0% 5 Missing ⚠️
...rc/org/rascalmpl/semantics/dynamic/Expression.java 0% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              main   #1914   +/-   ##
=======================================
- Coverage       49%     49%   -1%     
- Complexity    6164    6166    +2     
=======================================
  Files          661     661           
  Lines        58702   58708    +6     
  Branches      8547    8549    +2     
=======================================
+ Hits         28962   28964    +2     
- Misses       27550   27552    +2     
- Partials      2190    2192    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant