-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace lib:/// scheme by mvn:/// and file:/// and jar+file:/// everywhere #1969
base: main
Are you sure you want to change the base?
Conversation
…ion and configuration process by adding a messages field to PathConfig
… errors that PathConfig creation detects
tests to run
|
``` rascal>resolveLocation(|std:///|) loc: |jar+file:///Users/jurgenv/git/rascal/target/rascal-0.40.3-RC2-SNAPSHOT.jar!/org/rascalmpl/library/| ```
This PR fixes #1961 |
…hile testing from rascal/target/classes instead of from a jar file. now the tests can succeed as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've taken a first look at the code, not sure why everything is happening yet, but it seems like this will cause a whole downstream of changes and issues, so we're going to have to write down some new documentation of how it is supposed to be used I think.
…eflective for help in creating smart PathConfig instances
…with URL and URI hostname standards
…h renamed packages of jline
…functions to generate pom.xml and RASCAL.MF independently, for later use in quickfixes
…on the rascal project in the pom file
This PR:
lib:///
scheme. This also removes a lot of printing on stderr.mvn:///
schememessages
, including version clashes on the rascal and rascal-lsp project, missing pom.xml files, etc.These were the TODO's:
mvn:///groupid!artifactid!version
lib:///
in the processing of dependencies (Require-Libraries) with other schemes, includingmvn
,file
, andjar+file
. This means sometimes dynamically computing an absolute path rather than leaving it to an opaque scheme.lib:///
scheme that is now introduced by thePackager
. Some form of relocation is necessary, but it can't be the oldlib:///
scheme anymore.This fixes #1916, #1961, #1826, #1825, #1824, #1777, #1767, and #1478
Downstream projects like rascal-lsp and rascal-maven-plugin may need some modifications:
URIUtil.correctLocation("lib", name)
should becomePathConfig.resolveDependencyFromResourcesOnCurrentClasspath("name")
orURIUtil.correctLocation("mvn", etc.)