Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/remove auto disambiguation #2075

Open
wants to merge 3 commits into
base: feat/error-recovery
Choose a base branch
from

Conversation

PieterOlivier
Copy link
Contributor

@PieterOlivier PieterOlivier commented Nov 11, 2024

This PR removes the automatic disambiguation of error trees when allowRecovery=true but allowAmbiguity=false.

Note that in this case a separate check is needed for 'regular' ambiguities (which are not allowed).

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 16 lines in your changes missing coverage. Please review.

Project coverage is 49%. Comparing base (415773f) to head (40b1226).

Files with missing lines Patch % Lines
src/org/rascalmpl/library/util/ErrorRecovery.java 40% 6 Missing and 6 partials ⚠️
...rc/org/rascalmpl/semantics/dynamic/Expression.java 0% 2 Missing ⚠️
...g/rascalmpl/values/RascalFunctionValueFactory.java 0% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             feat/error-recovery   #2075   +/-   ##
=====================================================
  Coverage                     49%     49%           
- Complexity                  6605    6607    +2     
=====================================================
  Files                        685     685           
  Lines                      61148   61152    +4     
  Branches                    8850    8852    +2     
=====================================================
+ Hits                       30239   30244    +5     
+ Misses                     28706   28701    -5     
- Partials                    2203    2207    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PieterOlivier PieterOlivier mentioned this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant