Fixed the case where one of the alternative of an ambiguity is an emp… #2084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/error-recovery #2084 +/- ##
=====================================================
- Coverage 49% 49% -1%
+ Complexity 6604 6589 -15
=====================================================
Files 685 685
Lines 61145 61148 +3
Branches 8850 8850
=====================================================
- Hits 30243 30223 -20
- Misses 28701 28722 +21
- Partials 2201 2203 +2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when during error disambiguation one of the ambiguities consisted of an error tree with an empty "skipped" part (could only happen at the end of the file), that ambiguity was considered error-free. If there where other "regular" ambiguities in the ambiguity node, this node was not dropped as it should have been.
This PR fixes that.