Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/setup #1

Merged
merged 10 commits into from
Aug 22, 2024
Merged

Test/setup #1

merged 10 commits into from
Aug 22, 2024

Conversation

xlassix
Copy link
Collaborator

@xlassix xlassix commented Aug 21, 2024

  • Added .env Checks and its corresponding test-cases
  • Added Husky pre-commit and pre-push config

@xlassix xlassix requested a review from rsoury August 21, 2024 21:08
@rsoury rsoury merged commit 4ea388f into main Aug 22, 2024
1 check passed
@rsoury
Copy link
Member

rsoury commented Aug 22, 2024

Looks good.
Merged 💪

Continue to work on a branch - ie. develop

Re Joi : for some reason, I always used https://www.npmjs.com/package/zod instead, but I'm happy with the selection

@xlassix xlassix deleted the test/setup branch September 3, 2024 08:53
@xlassix
Copy link
Collaborator Author

xlassix commented Sep 3, 2024

Nice, Zod seems to be better at handling error messages.
Next project or if we have enough time left on this then will be moving to zod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants