Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support -9e as an argument for xz compression #101

Merged
merged 4 commits into from
Feb 1, 2024

Conversation

dtcooper
Copy link
Contributor

@dtcooper dtcooper commented Jan 31, 2024

Hi there,

This allows for a little more extreme compression with xz (which is what I believe Raspberry Pi uses for their distributables).

Thanks!

Copy link
Owner

@usimd usimd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your addition! Good idea to allow very aggressive compression, didn't even know of this setting 👍

Would you mind adding a test case to also hit the coverage?

src/pi-gen-config.ts Outdated Show resolved Hide resolved
@dtcooper
Copy link
Contributor Author

Thanks for your addition! Good idea to allow very aggressive compression, didn't even know of this setting 👍

Would you mind adding a test case to also hit the coverage?

I'm by no means a typescript expert, but I will try!

@dtcooper
Copy link
Contributor Author

Was having trouble writing a test...

@dtcooper
Copy link
Contributor Author

Okay! My trouble with the tests were one of the current tests wasn't working properly. It always threw an error because stageList wasn't properly converted to a list. I've fixed that test, tested for specific error cases, and added one for the new feature. Thanks!

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (014ec73) 96.16% compared to head (e831be5) 97.48%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
+ Coverage   96.16%   97.48%   +1.31%     
==========================================
  Files          12       12              
  Lines         391      437      +46     
  Branches       87      109      +22     
==========================================
+ Hits          376      426      +50     
- Misses          8       11       +3     
+ Partials        7        0       -7     
Flag Coverage Δ
unittests 97.48% <100.00%> (+1.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@usimd usimd added the test Run integration test in PR label Jan 31, 2024
@usimd
Copy link
Owner

usimd commented Jan 31, 2024

Awesome, thanks so much for your effort!

I'll have a closer look tomorrow but I assume this should be fine and we can then merge quickly.

@dtcooper
Copy link
Contributor Author

dtcooper commented Feb 1, 2024

Awesome, thanks so much for your effort!

I'll have a closer look tomorrow but I assume this should be fine and we can then merge quickly.

Great! Thanks!

Copy link
Owner

@usimd usimd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for your contribution!

@usimd usimd merged commit f3b6543 into usimd:master Feb 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Run integration test in PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants