-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support -9e as an argument for xz compression #101
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your addition! Good idea to allow very aggressive compression, didn't even know of this setting 👍
Would you mind adding a test case to also hit the coverage?
I'm by no means a typescript expert, but I will try! |
Was having trouble writing a test... |
Okay! My trouble with the tests were one of the current tests wasn't working properly. It always threw an error because |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #101 +/- ##
==========================================
+ Coverage 96.16% 97.48% +1.31%
==========================================
Files 12 12
Lines 391 437 +46
Branches 87 109 +22
==========================================
+ Hits 376 426 +50
- Misses 8 11 +3
+ Partials 7 0 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Awesome, thanks so much for your effort! I'll have a closer look tomorrow but I assume this should be fine and we can then merge quickly. |
Great! Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for your contribution!
Hi there,
This allows for a little more extreme compression with
xz
(which is what I believe Raspberry Pi uses for their distributables).Thanks!