Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove QCOW2 build config #108

Merged
merged 1 commit into from
Feb 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -156,11 +156,6 @@ tries to make sure the stage is respected and its changes are included in the fi
# System timezone.
timezone: Europe/London

# Use qcow2 images to reduce space and runtime requirements. _WARNING_: this is
# broken on recent versions of `pi-gen` and destined to be removed entirely (see
# https://github.com/RPi-Distro/pi-gen/pull/648).
use-qcow2: 0

# Name of the initial user account.
username: pi

Expand Down
6 changes: 0 additions & 6 deletions action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,6 @@ inputs:
description: The release name to use in `/etc/issue.txt`. The default should only be used for official Raspberry Pi builds.
required: false
default: Raspberry Pi reference
use-qcow2:
description: |
Use qcow2 images to reduce space and runtime requirements.
_WARNING_: this is broken on recent versions of `pi-gen` and destined to be removed entirely (see https://github.com/RPi-Distro/pi-gen/pull/648).
required: false
default: 0
setfcap:
description: |
Setting to `1` will prevent pi-gen from dropping the "capabilities" feature. Generating the root filesystem with capabilities enabled and running
Expand Down
1 change: 0 additions & 1 deletion src/configure.ts
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ export async function configure(): Promise<PiGenConfig> {
core.getInput('wpa-country') || DEFAULT_CONFIG.wpaCountry
userConfig.enableSsh =
core.getInput('enable-ssh') || DEFAULT_CONFIG.enableSsh
userConfig.useQcow2 = core.getInput('use-qcow2') || DEFAULT_CONFIG.useQcow2
userConfig.enableNoobs =
core.getBooleanInput('enable-noobs')?.toString() ||
DEFAULT_CONFIG.enableNoobs
Expand Down
2 changes: 0 additions & 2 deletions src/pi-gen-config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ export interface PiGenConfig {
pubkeyOnlySsh: string
setfcap?: string
stageList: string[]
useQcow2: string
enableNoobs: string
exportLastStageOnly: string
dockerOpts?: string
Expand All @@ -47,7 +46,6 @@ export const DEFAULT_CONFIG: PiGenConfig = {
enableSsh: '0',
pubkeyOnlySsh: '0',
stageList: ['stage*'],
useQcow2: '0',
enableNoobs: 'false',
exportLastStageOnly: 'true'
}
Expand Down
Loading