Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llava binding #214

Closed
wants to merge 18 commits into from
Closed

llava binding #214

wants to merge 18 commits into from

Conversation

tinglou
Copy link
Contributor

@tinglou tinglou commented Mar 21, 2024

  1. llava multimodel api
  2. ollama local repo access

@tinglou
Copy link
Contributor Author

tinglou commented Mar 21, 2024

Related PR
ggml-org/llama.cpp#6079

@MarcusDunn
Copy link
Contributor

Thanks for the PR, it's well written and I appreciate the tests!

Unfortunately, I do not feel like I can maintain bindings to examples or common (you'll notice there is a rust version of grammar parsing for example).

If we can replace these with Rust, or if llama.cpp moves the required API's to llama.h (as they plan to do for common/sampling.cpp) I would reconsider llava support.

@MarcusDunn MarcusDunn closed this Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants