-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SC-5] Added about us page #8
Conversation
<div className="grid grid-cols-1 md:grid-cols-3 gap-4 px-12"> | ||
<div className="bg-gray-100 p-4 rounded shadow"> | ||
<h2 className="font-bold mb-2">What we do:</h2> | ||
<p>After we received your donations, we purchase your chosen stock and hold it*. Every month, we will donate the dividends to your preferred charity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the * after it intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes it is, if u think its confusing then i'll remove it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh not at all just making sure
</div> | ||
<div className="bg-gray-100 p-4 rounded shadow"> | ||
<h2 className="font-bold mb-2">Find us on other platforms!</h2> | ||
<p>Instagram: @stockcharity</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section is filled with a lot of empty space, maybe you could center the content?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code wise, this LGTM just some suggestions with some of the content. Also i personally am not a huge fan of the grey on black but styling can be dealt with later.
Added the descriptions of Stock Charity for the page.
Screenshot of the page: