Add stringToName special case for all-underscores identifier strings #1260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the compilation fails because github updated the |
|
Indeed. I'll rebase this (and #1261) on |
Before, parsing the following PVL program would give an assertion error, since it would attempt to build a preferred name with no parts:
```
void ___() {
}
```
It now gets a preferred name with one part, the string "___".
Also adds a unit test for stringToName.
wandernauta
force-pushed
the
underscore
branch
from
d9cf473
to
bb2d0f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, parsing the following PVL program like the following would give an assertion error, since it would attempt to build a preferred name with no parts:
void ___() { }It now gets a preferred name with one part, the string "___".
Also adds a unit test for stringToName.